Generalize VE.Direct to SolarCharger #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlimmchen
commented
Dec 3, 2024
AndreasBoehm
force-pushed
the
rename-vedirect-to-solarcharger
branch
4 times, most recently
from
cad70b1 to
8c0ecbc
Compare
AndreasBoehm
reviewed
Dec 7, 2024
AndreasBoehm
reviewed
Dec 7, 2024
AndreasBoehm
reviewed
Dec 7, 2024
AndreasBoehm
force-pushed
the
rename-vedirect-to-solarcharger
branch
2 times, most recently
from
f61f456 to
f43b7a5
Compare
This was referenced Dec 13, 2024
AndreasBoehm
force-pushed
the
rename-vedirect-to-solarcharger
branch
2 times, most recently
from
d11be3b to
a3d0408
Compare
AndreasBoehm
force-pushed
the
rename-vedirect-to-solarcharger
branch
2 times, most recently
from
08e5b9a to
635a450
Compare
AndreasBoehm
force-pushed
the
rename-vedirect-to-solarcharger
branch
from
635a450 to
4de3cb1
Compare
Because this view shows the same information as the configuration I figured that we can remove it and avoid the hassle of refactoring it.
AndreasBoehm
force-pushed
the
rename-vedirect-to-solarcharger
branch
from
4811e65 to
9e73fcc
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is @AndreasBoehm's work to start generalizing the VE.Direct implementation into an abstract solar charger, which allows to later add a different provider/implementation (MQTT) retrieving info related to the solar charger in a system.